Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows downloading songs that aren't currently playing #221

Merged
merged 1 commit into from
Apr 3, 2021

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Apr 3, 2021

Fix #210 , Fix #219

This makes it so Downloader plugin use the URL of the song that the menu was opened from
(More accurately, it will use the URL of the radio mix for the song, taken from the same menu)

Also Fix #84 - plugin will no longer randomly download a playlist when trying to download a single song from the menu

This is also fully compatible with playlist downloading - effectively allowing users to download 'anything' without having to play it

Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution!

plugins/downloader/front.js Show resolved Hide resolved
@th-ch th-ch merged commit dc5d257 into th-ch:master Apr 3, 2021
@Araxeus Araxeus deleted the download-song-that-isnt-playing branch April 6, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve downloader Download button not working. Doesn't download some music
2 participants