Mpris support #394
Closed
Mpris support #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor and css fix xo --fix add inline doc fix typo
…into menu-fixes
Button would not transmit event
Delete notification on windowclosed Refactor notifications.utils.setOption
This reverts commit 80b1207.
(electron 11.4.2 fixed the bug that required that)
Snyk has created this PR to upgrade @cliqz/adblocker-electron from 1.20.3 to 1.20.4. See this package in npm: See this project in Snyk: https://app.snyk.io/org/th-ch/project/81809c53-bb7b-46b9-a0d7-806d45d74ac6?utm_source=github&utm_medium=upgrade-pr
Fix downloader plugin
Snyk has created this PR to upgrade electron-updater from 4.3.9 to 4.3.10. See this package in npm: See this project in Snyk: https://app.snyk.io/org/th-ch/project/81809c53-bb7b-46b9-a0d7-806d45d74ac6?utm_source=github&utm_medium=upgrade-pr
Snyk has created this PR to upgrade chokidar from 3.5.1 to 3.5.2. See this package in npm: See this project in Snyk: https://app.snyk.io/org/th-ch/project/81809c53-bb7b-46b9-a0d7-806d45d74ac6?utm_source=github&utm_medium=upgrade-pr
…3950b3384b3bce29 [Snyk] Upgrade chokidar from 3.5.1 to 3.5.2
…rade-4809caaf0847354b9b537aa0f8a0999d # By TC (1) and snyk-bot (1) # Via GitHub (1) and TC (1) * 'master' of github.com:th-ch/youtube-music: Bump ytdl/ytpl fix: upgrade chokidar from 3.5.1 to 3.5.2
…9b537aa0f8a0999d [Snyk] Upgrade electron-updater from 4.3.9 to 4.3.10
Bump node to v14
Add "Listen Along" button, solve th-ch#353
|
His @itzmanish thank you very much for this new feature. I'm afraid that this is a rather large PR: would it be possible for us to minimize its size?
This will make for a much easier code review and will ensure both the git log and the git blame stay clean |
|
Or let me simply create another PR with cherry pick. |
|
We can close this and new PR is on #395 |
Yes so close this one 😅 |
|
Let @th-ch do the closing part. |
th-ch
added a commit
that referenced
this pull request
Sep 6, 2021
Add mpris support with cherry picked commit from previous PR #394
|
Thanks for the contribution on Mpris, #395 has been merged, closing this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed conflicts with master branch.
Tested and working with playerctl