Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xesam:artist should be a list #539

Merged
merged 1 commit into from
Jan 7, 2022
Merged

xesam:artist should be a list #539

merged 1 commit into from
Jan 7, 2022

Conversation

markbaas
Copy link
Contributor

@markbaas markbaas commented Jan 4, 2022

According to mpris specs artists should be a list of strings:

https://www.freedesktop.org/wiki/Specifications/mpris-spec/metadata/#xesam:artist

Thus this was not working in gnome-shell :(

th-ch
th-ch approved these changes Jan 7, 2022
View reviewed changes
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix! ✅

@th-ch th-ch merged commit ec4c2e9 into th-ch:master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th-ch th-ch th-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markbaas @th-ch