Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show a badge remaining items when downloading a playlist #550

Merged
merged 3 commits into from
Jan 16, 2022
Merged

show a badge remaining items when downloading a playlist #550

merged 3 commits into from
Jan 16, 2022
+9 −2

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Jan 12, 2022 •
edited
Loading

#

badge shows remaining tracks to download

only works on linux and macOS, thus I couldn't personally test this since im on windows.

can any mac/linux dev/user test and confirm it works?

@Araxeus Araxeus changed the title set badge on downloader playlist show a badge remaining items when downloading a playlist Jan 13, 2022
th-ch
th-ch approved these changes Jan 16, 2022
View reviewed changes
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the improvement! ✅

@th-ch
Copy link
Owner

th-ch commented Jan 16, 2022

Merging as is, will backport the missing changes from the last merge

@th-ch th-ch merged commit 96f0d30 into th-ch:master Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th-ch th-ch th-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Araxeus @th-ch