Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[video-toggle] Fixed aligning running before #main-panel exists #956

Merged
merged 2 commits into from
Jan 14, 2023

Conversation

MiepHD
Copy link
Contributor

@MiepHD MiepHD commented Jan 9, 2023

This can possibly break the plugin (and it did for me, multiple time) Cannot read properties of undefined. mainpanel.style.setProperty("--align", "0px");

this whole code block needs to be inside an apiLoaded closure, we can't guarantee that $('#main-panel') exists when this code is called

In other words, instead of being inside the default export function, it should be inside the setup function which is called only when the page is loaded

@MiepHD @th-ch plz fix

@Araxeus
Copy link
Collaborator

Araxeus commented Jan 9, 2023

thanks

@th-ch th-ch merged commit 9b14a27 into th-ch:master Jan 14, 2023
@Araxeus Araxeus changed the title Fixed video-toggle aligning running before #main-panel exists [video-toggle] Fixed aligning running before #main-panel exists Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants