Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[discord] auto reconnect rpc and CSP fix #961

Merged
merged 5 commits into from
Feb 12, 2023
Merged

[discord] auto reconnect rpc and CSP fix #961

merged 5 commits into from
Feb 12, 2023
+70 −40

Conversation

xhayper
Copy link
Contributor

@xhayper xhayper commented Jan 11, 2023 •
edited
Loading

implemented #952.

and fix an issue regarding CSP to music.youtube.com, youtube.com, accounts.google.com and google.com.

@Zo-Bro-23
Copy link
Contributor

My RPC package doesn't support auto-reconnect out-of-the-box, but it's easy to implement it by using the code i provide.

I won't be adding auto-reconnect feature sadly...

Does this PR mean that I don't have to work on the auto-reconnect feature anymore or am I misunderstanding something? (you seem to have already incorporated that, so that's why I'm asking)

@xhayper
Copy link
Contributor Author

xhayper commented Jan 12, 2023 •
edited
Loading

You don't have to work auto-reconnect anymore as i already add it in this PR.

Araxeus
Araxeus reviewed Jan 12, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
th-ch
th-ch reviewed Jan 14, 2023
View reviewed changes
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, looks good otherwise!

package.json Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@xhayper
Copy link
Contributor Author

xhayper commented Jan 15, 2023

Sorry for being late!

@xhayper xhayper requested review from th-ch and Araxeus and removed request for th-ch January 22, 2023 15:47
Araxeus
Araxeus approved these changes Jan 22, 2023
View reviewed changes
Copy link
Collaborator

@Araxeus Araxeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@xhayper xhayper requested a review from th-ch January 23, 2023 02:30
@Araxeus Araxeus mentioned this pull request Jan 23, 2023
Closed
@xhayper
Copy link
Contributor Author

xhayper commented Feb 9, 2023

@th-ch sorry for the mention, but i have resolved the merge conflict and PR is now ready for a review!

th-ch
th-ch approved these changes Feb 12, 2023
View reviewed changes
package.json
Comment on lines -140 to -147
"resolutions": {
"glob-parent": "5.1.2",
"minimist": "1.2.7",
"yargs-parser": "21.1.1"
},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if all resolutions were outdated, but it should be ok to clean them, we'll see if some new resolutions are needed.

@th-ch
Copy link
Owner

th-ch commented Feb 12, 2023

Merging as is, I'll update the yarn.lock file for the new dependency

@th-ch th-ch merged commit 0e68344 into th-ch:master Feb 12, 2023
@xhayper xhayper deleted the patch-1 branch February 12, 2023 23:31
@xhayper xhayper mentioned this pull request Feb 13, 2023
Closed
@Araxeus Araxeus changed the title feat: auto reconnect rpc and CSP fix [discord] auto reconnect rpc and CSP fix Mar 15, 2023
@Araxeus Araxeus mentioned this pull request Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th-ch th-ch th-ch approved these changes

@Araxeus Araxeus Araxeus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xhayper @Zo-Bro-23 @th-ch @Araxeus