Potential bug (Missing initialization of some structures) #801
Assignees
Comments
fxlb
added a commit
to fxlb/tcpdump
that referenced
this issue
Dec 18, 2020
This change fixes the GH issue the-tcpdump-group#801. Same way as commit 88135db.
fxlb
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We noticed the following inconsistencies in tcpdump.
https:/the-tcpdump-group/tcpdump/blob/master/print-juniper.c#L884
ndo->ndo_protocol = "juniper_mfr"; memset(&l2info, 0, sizeof(l2info)); l2info.pictype = DLT_JUNIPER_MFR;https:/the-tcpdump-group/tcpdump/blob/master/print-juniper.c#L615
ndo->ndo_protocol = "juniper_monitor"; l2info.pictype = DLT_JUNIPER_MONITOR;https:/the-tcpdump-group/tcpdump/blob/master/print-juniper.c#L486
ndo->ndo_protocol = "juniper_ggsn"; l2info.pictype = DLT_JUNIPER_GGSN;We think either initializing l2info is missing in the latter cases or memset is unnecessary in the first case.
Thank you!
The text was updated successfully, but these errors were encountered: