feature advanced seeking #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Nice work @boxyardboy -- the new functionality is sweeeeeeeeet!!
See comments below...
js/controller.js
Outdated
| @@ -1269,6 +1273,10 @@ OO.plugin("Html5Skin", function (OO, _, $, W) { | |||
| } | |||
| break; | |||
| case CONSTANTS.STATE.PAUSE: | |||
| if (this.actualVideoObject !== null) { | |||
There was a problem hiding this comment.
@boxyardboy -- this is an example of where the pause state is coupled with the playback rate.
I would personally advocate not changing the playback rate back to 1 when the video is paused. My reasons are:
- From a "defensive coding" point of view when working with state machines I like to try not to incur more state changes then are necessary
- I think it's a more expected user experience to not change the playback rate when pause is enabled (I could be mistaken about this and would defer to user tests and @steve-schultz here).
- I think we are going to want an "enabled" button state for the slow-mo feature so people can easily see when it is enabled. If we are going to change back to 1.0 then we would want to also make sure the button state of any slow-mo buttons gets updated as well.
Another example of decoupling the play/paused state is when you seek backwards 10 seconds. If the video is paused when you press this button, I would advocate not playing the video again. Once again happy to defer to user tests or @steve-schultz here.
| }, | ||
|
|
||
| slowMoOneHalf: function() { | ||
| var rate = this.actualVideoObject.playbackRate === 0.5 ? 1 : 0.5; |
There was a problem hiding this comment.
Nice! this is exactly what I was talking about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specs detailed in this task:
https://app.asana.com/0/366794583153092/420464749122084/f