Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement more of the Query interface #23

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Implement more of the Query interface #23

merged 4 commits into from
Feb 15, 2024

Conversation

darinf
Copy link

@darinf darinf commented Feb 13, 2024

Adds addSnapshotListener and fleshes out QuerySnapshot.

brianmichel
brianmichel approved these changes Feb 14, 2024
View reviewed changes
Copy link

@brianmichel brianmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, only a few small comments/questions

Sources/FirebaseFirestore/NSError+FirestoreError.swift Show resolved Hide resolved
Sources/FirebaseFirestore/Query+Swift.swift Outdated Show resolved Hide resolved
Sources/FirebaseFirestore/QuerySnapshot+Swift.swift Show resolved Hide resolved
Base automatically changed from darin/expose-source-param to main February 15, 2024 00:16
@darinf darinf merged commit 24d25ec into main Feb 15, 2024
@darinf darinf deleted the darin/query-support-part2 branch February 15, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmichel brianmichel brianmichel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darinf @brianmichel