Add test for IVector being IIterable #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbrix
requested changes
Apr 15, 2024
stevenbrix
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a skipped test that would pass if #159 were implemented.
I believe this doesn't work and would be nontrivial to implement. When a Swift-implemented
IVector<T>is passed to WinRT, we create a COM-exposable wrapper specific to top-level interface,IVector<T>, but that wrapper does not know how to provide additional required interfaces,IIterable<T>in this case. More generally, the wrapper would have no way to know that the Swift object implements other interfaces (for exampleIClosable).IVector<T>'s queryInterface cannot respond toIIterable<T>because the GUID and wrapper types are different for eachT.