Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tab issues #444

Closed
newyhj opened this issue May 5, 2022 · 8 comments
Closed

tab issues #444

newyhj opened this issue May 5, 2022 · 8 comments

Comments

@newyhj
Copy link

newyhj commented May 5, 2022

Scene 1

when tab-pane not have "fade" class, nav-link .active class cannot be set correctly

Scene 2

tab-pane has "fade" class, when i quick click nav link,cant switch tab pane!
@thednp
Copy link
Owner

thednp commented May 5, 2022

Have a demo?

@newyhj
Copy link
Author

newyhj commented May 8, 2022

https://jsfiddle.net/newyhj/a9zcvfe6/11/

please see above code

@thednp
Copy link
Owner

thednp commented May 8, 2022

Thanks will have a look asap.

@thednp
Copy link
Owner

thednp commented May 18, 2022

Just to let you know, the Tab issue is fixed, will let you know once I'm done with a new build, currently doing a major code revisit.

Sorry it took me a while to reply.

@newyhj
Copy link
Author

newyhj commented May 21, 2022

good.

thednp added a commit that referenced this issue May 27, 2022
* Added Cypress tests ~99% coverage
* Removed V4, to be moved to a different branch
* Fixing Tab issue #444
* Minor fix for Button.isActive property
* Carousel no longer use touch events but a standardized pointer event listener setup
* Dropdown improvements for automatic positioning
* Tooltip, Popover small fixes with their shared utilities
 Modal and Offcanvas will use a callback for dispose() method combined with specific hide() / close() method
* Minor fixes to allow working with iframes, bugs revealed by Cypress testing
* Code cleanup
* Update Types

TO DO:
* update to latest Bootstrap v5.2.0
@thednp
Copy link
Owner

thednp commented May 27, 2022

@newyhj please test the latest master.

@newyhj
Copy link
Author

newyhj commented May 29, 2022

it's seems ok,prefect

@thednp
Copy link
Owner

thednp commented May 30, 2022

Alright, we can close this one and release 4.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants