Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown now working properly on beta #145

Closed
wants to merge 1 commit into from
Closed

Dropdown now working properly on beta #145

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 11, 2017

No description provided.

@thednp
Copy link
Owner

thednp commented Aug 11, 2017

Will this commit also work with nested dropdown menus? At the first sight I would say it wouldn't.

@ghost
Copy link
Author

ghost commented Aug 11, 2017

@thednp what you mean under nested dropdown menus? I didn't found that in docs

@ghost
Copy link
Author

ghost commented Aug 11, 2017

There is no nested dropdown menus in beta

@thednp
Copy link
Owner

thednp commented Aug 11, 2017

Look at the fourth example in the right here.

@ghost
Copy link
Author

ghost commented Aug 11, 2017

But it's works
image

@thednp
Copy link
Owner

thednp commented Aug 11, 2017

Try your code with this sample code

<div class="dropdown">
  <a id="drop2" href="#" class="dropdown-toggle" data-toggle="dropdown" data-trigger="mouseover" aria-haspopup="true" role="button" aria-expanded="false">Nested <span class="caret"></span></a>
  <ul class="dropdown-menu pull-right" role="menu" aria-labelledby="drop2" tabindex="0" aria-expanded="true">
    <li role="presentation"><a role="menuitem" tabindex="-1" href="#">Action</a></li>
    <li role="presentation"><a role="menuitem" tabindex="-1" href="#">Another action</a></li>
    <li role="presentation"><a role="menuitem" tabindex="-1" href="#">Something else here</a></li>
    <li role="presentation" class="divider"></li>
    <li role="presentation" class="dropdown">
      <a role="menuitem" tabindex="-1" href="#" data-toggle="dropdown">Sub-menu <span class="caret"></span></a>
      <ul class="dropdown-menu left" role="menu" aria-labelledby="drop3" tabindex="0" aria-expanded="false">
        <li role="presentation"><a role="menuitem" tabindex="-1" href="#">Level 1</a></li>
        <li role="presentation"><a role="menuitem" tabindex="-1" href="#">Nested Menu</a></li>
        <li role="presentation" class="dropdown">
          <a role="menuitem" tabindex="-1" href="#" data-toggle="dropdown">Other stuff <span class="caret"></span></a>
          <ul class="dropdown-menu left" role="menu" aria-labelledby="drop4" tabindex="0" aria-expanded="false">
            <li role="presentation"><a role="menuitem" tabindex="-1" href="#">Level 2</a></li>
            <li role="presentation"><a role="menuitem" tabindex="-1" href="#">Nested Menu</a></li>
            <li role="presentation" class="dropdown">
              <a role="menuitem" tabindex="-1" href="#" data-toggle="dropdown">Even more stuff <span class="caret"></span></a>
              <ul class="dropdown-menu left" role="menu" aria-labelledby="drop4" tabindex="0">
                <li role="presentation"><a role="menuitem" tabindex="-1" href="#">Level 3</a></li>
                <li role="presentation"><a role="menuitem" tabindex="-1" href="#">Nested Menu</a></li>
              </ul>
            </li>
          </ul>
        </li>
      </ul>
    </li>
  </ul>
</div>

@ghost
Copy link
Author

ghost commented Aug 11, 2017

image

@thednp
Copy link
Owner

thednp commented Aug 11, 2017

OK let's take it this way, show me an example where my code doesn't work.

@ghost
Copy link
Author

ghost commented Aug 11, 2017

@thednp what do you mean?

@thednp
Copy link
Owner

thednp commented Aug 11, 2017

I mean a page example where the code is faulty.

@thednp thednp closed this Aug 11, 2017
@ghost
Copy link
Author

ghost commented Aug 11, 2017

Why you closed this????

@ghost
Copy link
Author

ghost commented Aug 11, 2017

@thednp
Copy link
Owner

thednp commented Aug 12, 2017

Yea, some class have been changed with V4 beta, will have a look at it.

@thednp
Copy link
Owner

thednp commented Aug 12, 2017

@ctl have you found anything else with V4?

@ghost
Copy link
Author

ghost commented Aug 12, 2017

@thednp , no. Possibly everything else is working.

@thednp
Copy link
Owner

thednp commented Aug 12, 2017

@ctl your issue is fixed now, however, it's a bit different than your commit, so I will make proper commit, but will let you know asap.

@thednp
Copy link
Owner

thednp commented Aug 12, 2017

It seems I hav to update more than just the Dropdown, Popover and Tooltip are also out of date.

thednp added a commit that referenced this pull request Aug 12, 2017
* Tooltip and Popover updated
* Dropdown updated, thanks to @ctl for #145
* Documentation updates
* Version bump
thednp added a commit that referenced this pull request Aug 12, 2017
* Tooltip and Popover updated
* Dropdown updated, thanks to @ctl for #145
* Documentation updates
* Version bump
@thednp
Copy link
Owner

thednp commented Aug 12, 2017

@ctl please download latest master and do some tests, changes here 80a187f

@thednp
Copy link
Owner

thednp commented Aug 12, 2017

@ctl I need your confirmation before I push the update to the clouds and npm.

@ghost
Copy link
Author

ghost commented Aug 12, 2017

@thednp , Sorry for late response , but i wasn't at home . I'll try now

@ghost
Copy link
Author

ghost commented Aug 12, 2017

@thednp , it's works properly

@ghost
Copy link
Author

ghost commented Aug 13, 2017

I mean dropdowns , tooltips , popovers

@thednp
Copy link
Owner

thednp commented Aug 13, 2017

Thanks, so we're safe to do a release perhaps, but I'm waiting for more people to get their hands on.

@thednp
Copy link
Owner

thednp commented Aug 15, 2017

@ctl the latest version is now live on npm and soon to be available on the CDN clouds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant