Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using "Transforms" Figma detects style changes #39

Closed
aesign opened this issue Mar 28, 2022 · 2 comments
Closed

When using "Transforms" Figma detects style changes #39

aesign opened this issue Mar 28, 2022 · 2 comments

Comments

@aesign
Copy link

aesign commented Mar 28, 2022

I've been using the "opacity" transform and everything works. The problem is that Figma detects style changes to be published every time I open Theemo (even if I don't make any edit).

@gossi
Copy link
Member

gossi commented Apr 6, 2022

Hmm, I think this is a bit "by design" - but by Figma's design.

So, theemo has a "thread", that runs ~every second, that updates the styles while you make changes. For example, when you do have a color palette and reference those to your design tokens, then you can update the colors in the styles panel and a little later those references are updated automatically through this.

That is, these changes are made, it isn't checked if differences are detected (might be an addition to theemo here) and then these styles are applied (even if there are no differences). It is a tricky area, as this is a performant critical component, adding those diff checks might be good for one but disaster to another.

I will need to see what's available through the Figma API (they made changes) and what can be done as part of this plugin. That is, I can't promise you anything right now.

A little "workaround" might be to go to Tools and turn off Auto Update Style References.

Thanks for your input, I like that. Hope that answer clarifies a little, why that isn't trivial for now to do.

@gossi gossi transferred this issue from theemo-tokens/theemo Jan 21, 2023
@gossi
Copy link
Member

gossi commented Jan 24, 2024

Fixed with #57 (using new styles API)

@gossi gossi closed this as completed Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants