Fix the 6-bit Caught Level to record Pokemon > Level 63 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
reviewed
May 27, 2022
Rangi42
reviewed
May 27, 2022
Rangi42
reviewed
May 27, 2022
Co-authored-by: Rangi <[email protected]>
vulcandth
added a commit
that referenced
this pull request
May 30, 2022
* Fix Caught Level * Change MON_EMPTY_BIT to rb_skip Co-authored-by: Rangi <[email protected]> Co-authored-by: Rangi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fix this by moving the
CAUGHT_TIME_MASKbits (%11000000) to the first byte inMON_EXP.MON_EXPhas three free bits that are never used. This givesMON_CAUGHTLEVELa whole byte to itself, with one free bit.This is related to pret#901