Fix/spatial mixins #736
Merged
Fix/spatial mixins #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MUCDK
reviewed
Jul 17, 2024
MUCDK
requested changes
Jul 17, 2024
giovp
approved these changes
Jul 18, 2024
Thanks for your feedback @MUCDK, I added that minor change to the docs, extended tests to cover this case, spotted a corner case and fixed it. Everything should be fine now. |
|
Great, thanks Marius! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a batched mode for
correlateandimpute, offering a temporary fix for #729.