Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some notebooks need refactoring and/or fixing #74

Closed
selmanozleyen opened this issue Jun 12, 2024 · 1 comment · Fixed by #77
Closed

Some notebooks need refactoring and/or fixing #74

selmanozleyen opened this issue Jun 12, 2024 · 1 comment · Fixed by #77

Comments

@selmanozleyen
Copy link

While working on this PR:theislab/moscot#696 some notebooks failed because the PR currently sends error when an argument is ignored or when kwargs is given in kwargs=x but we would rather use **x form now.

Take this code snippet for example

mp = mp.prepare(
    sc_attr={"attr": "obsm", "key": "X_pca"}, kwargs={"callback_kwargs": "local_pca"}
)

ideally instead of this we would use this

mp = mp.prepare(
    sc_attr={"attr": "obsm", "key": "X_pca"},**{"callback_kwargs": "local_pca"}
)

because the kwargs argument will be removed in the future. However in this case it would still throw an error since callback_kwargs is an invalid argument (probably has to be xy_callback_kwargs). This means in the notebooks these kwargs were just ignored.

To see which cells of the notebooks failed you can check these test results
https:/theislab/moscot/actions/runs/9488695422/job/26148224156?pr=696

ping: @ArinaDanilina @giovp @MUCDK

@ArinaDanilina ArinaDanilina linked a pull request Jun 18, 2024 that will close this issue
@selmanozleyen
Copy link
Author

Hi the notebooks still don't pass on my PR. https:/theislab/moscot/actions/runs/9666061798/job/26664685331?pr=696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant