generated from theislab/sc_analysis_template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some notebooks need refactoring and/or fixing #74
Comments
Merged
Merged
Hi the notebooks still don't pass on my PR. https:/theislab/moscot/actions/runs/9666061798/job/26664685331?pr=696 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While working on this PR:theislab/moscot#696 some notebooks failed because the PR currently sends error when an argument is ignored or when kwargs is given in
kwargs=x
but we would rather use**x
form now.Take this code snippet for example
ideally instead of this we would use this
because the
kwargs
argument will be removed in the future. However in this case it would still throw an error sincecallback_kwargs
is an invalid argument (probably has to bexy_callback_kwargs
). This means in the notebooks these kwargs were just ignored.To see which cells of the notebooks failed you can check these test results
https:/theislab/moscot/actions/runs/9488695422/job/26148224156?pr=696
ping: @ArinaDanilina @giovp @MUCDK
The text was updated successfully, but these errors were encountered: