Skip to content
Build

feat: add validation for run configuration #55

Sign in to view logs

feat: add validation for run configuration

feat: add validation for run configuration #55

GitHub Actions / Qodana Community for JVM completed Sep 28, 2024 in 0s

34 new problems found by Qodana Community for JVM

Qodana Community for JVM

34 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 8
Redundant nullable return type 🔶 Warning 7
Redundant call of conversion method 🔶 Warning 4
Redundant semicolon 🔶 Warning 3
Serializable object must implement 'readResolve' 🔶 Warning 1
Leaking 'this' in constructor 🔶 Warning 1
Redundant SAM constructor 🔶 Warning 1
Class member can have 'private' visibility ◽️ Notice 4
Variable declaration could be moved inside 'when' ◽️ Notice 1
Replace empty class body ◽️ Notice 1
'if' condition can be replaced with lambda call ◽️ Notice 1
'map.put()' can be converted to assignment ◽️ Notice 1
Call chain on collection type can be simplified ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 5 in src/main/kotlin/com/github/themartdev/intellijgleam/lang/GleamLanguage.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Serializable object must implement 'readResolve' 

Serializable object must implement 'readResolve'

Check warning on line 24 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/ui/components/AbstractPathComboBox.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Leaking 'this' in constructor 

Calling non-final function addActionListener in constructor

Check notice on line 34 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/common/FsUtils.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Class member can have 'private' visibility 

Function 'isValidDir' could be private

Check notice on line 16 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/ui/components/AbstractPathComboBox.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Class member can have 'private' visibility 

Property 'collectionModel' could be private

Check notice on line 22 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/runconf/run/GleamRunConfigurationEditor.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Class member can have 'private' visibility 

Property 'useCustomGleam' could be private

Check notice on line 123 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/ui/components/AbstractPathComboBox.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Class member can have 'private' visibility 

Property 'homePath' could be private

Check notice on line 57 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/ui/components/AbstractPathComboBox.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Variable declaration could be moved inside 'when' 

Variable declaration could be moved into 'when'

Check warning on line 115 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/common/ErlangSdkFinder.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Redundant nullable return type 

'captureErlang' always returns non-null type

Check warning on line 47 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/runconf/run/GleamRunConfiguration.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Redundant nullable return type 

'getState' always returns non-null type

Check warning on line 60 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/common/GleamExecutableFinder.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Redundant nullable return type 

'captureGleam' always returns non-null type

Check warning on line 23 in src/main/kotlin/com/github/themartdev/intellijgleam/lang/psi/impl/GleamPsiImplUtil.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Redundant nullable return type 

'getNameOrAlias' always returns non-null type

Check warning on line 24 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/editor/GleamFoldingBuilder.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Redundant nullable return type 

'getPlaceholderText' always returns non-null type

Check warning on line 15 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/runconf/run/GleamConfigurationFactory.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Redundant nullable return type 

'getOptionsClass' always returns non-null type

Check warning on line 59 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/formatter/GleamCodeStyleSettingsProvider.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Redundant nullable return type 

'getIndentOptionsEditor' always returns non-null type

Check warning on line 38 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/formatter/lsp/GleamAbstractLspFormattingServiceProxy.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Redundant SAM constructor 

Redundant SAM constructor

Check warning on line 14 in src/main/kotlin/com/github/themartdev/intellijgleam/lang/psi/impl/GleamPsiImplUtil.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Redundant semicolon 

Redundant semicolon

Check warning on line 112 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/ui/GleamSettingsConfigurable.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Redundant semicolon 

Redundant semicolon

Check warning on line 123 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/ui/GleamSettingsConfigurable.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Redundant semicolon 

Redundant semicolon

Check notice on line 7 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/formatter/GleamCodeStyleSettings.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Replace empty class body 

Redundant empty class body

Check warning on line 30 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/ui/components/ErlangPathComboBox.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Redundant call of conversion method 

Remove redundant calls of the conversion method

Check warning on line 13 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/ui/components/ErlangPathComboBox.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Redundant call of conversion method 

Remove redundant calls of the conversion method

Check warning on line 30 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/ui/components/GleamPathComboBox.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Redundant call of conversion method 

Remove redundant calls of the conversion method

Check warning on line 13 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/ui/components/GleamPathComboBox.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

Redundant call of conversion method 

Remove redundant calls of the conversion method

Check notice on line 36 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/formatter/GleamFormatBlock.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

'if' condition can be replaced with lambda call 

Replace with 'ifEmpty {...}'

Check notice on line 40 in src/main/kotlin/com/github/themartdev/intellijgleam/ide/runconf/run/GleamRunConfigurationState.kt

See this annotation in the file changed.

@github-actions github-actions / Qodana Community for JVM

'map.put()' can be converted to assignment 

map.put() should be converted to assignment
View more details on GitHub Actions