Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug after model refresh #17

Closed
cxq opened this issue Mar 13, 2014 · 3 comments
Closed

bug after model refresh #17

cxq opened this issue Mar 13, 2014 · 3 comments

Comments

@cxq
Copy link

cxq commented Mar 13, 2014

Hi,
Actually, I generate a list of items with the your slider that could change at anytime.
When It happens, the slider is refreshed with no item inside the slider.

Could you please have a look at it ?

Thank you for your work.

@thenikso
Copy link
Owner

thenikso commented Apr 4, 2014

Could you provide a code example that reproduce the issue?

@jmallison
Copy link

Ran into this issue too. A single model update removes all slides, a subsequent model update adds all slides back. Debugged the code and found the issue - one line had it's code inverted.

Line 78
Current Code:
trackCollection[c] = getTrackFromItem(c);

Correct Code:
trackCollection[getTrackFromItem(c)] = c;

The ordinal definition is just in the wrong spot ;-)

After this change, updating models works great, add/remove is seamless and awesome. Thanks for this project!

@thenikso
Copy link
Owner

thenikso commented May 4, 2014

Nice catch! This is what you get when you don't unit test -_-'

wilsonwc pushed a commit to wilsonwc/angular-flexslider that referenced this issue Aug 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants