Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splicing slides intermittently creates blank slides #27

Open
olegtim opened this issue Jul 19, 2014 · 5 comments
Open

Splicing slides intermittently creates blank slides #27

olegtim opened this issue Jul 19, 2014 · 5 comments

Comments

@olegtim
Copy link

olegtim commented Jul 19, 2014

I am testing this with an array of 10 slides and while adding slides and shifting works fine, when I try to splice by index, I start getting blank slides after a few splices.

@pgerochi
Copy link

I am having a similar issue, although it only happens when it's the last item left in an array.

@thenikso
Copy link
Owner

Could you prepare a plunkr (maybe starting from this one) to reproduce the issue?

@wilsonwc
Copy link

wilsonwc commented Aug 8, 2014

I think this illustrates this issue when adding slides. Not sure if it does the same for removing slides: http://plnkr.co/edit/snzP7sgG7ymXOqYD0JkX?p=preview

@wilsonwc
Copy link

wilsonwc commented Aug 8, 2014

This one seems to fix the issue with my updated fork: http://plnkr.co/edit/ZvPns7JnJ4zHMCRfjqoI?p=preview (clicking add slides doesn't do a total refresh and only show 4 slides)

@thenikso
Copy link
Owner

@wilsonwc could you file a PR with the fix?

nikhiln added a commit to nikhiln/angular-flexslider that referenced this issue Mar 19, 2015
nikhiln added a commit to nikhiln/angular-flexslider that referenced this issue Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants