Puppet 8 Does not support legacy fact values

[cvquesty]

When executing a puppet run on Puppet 8, Puppet no longer recognizes facts such as ::osfamily when executing a run. sysctl/manifests/params.pp line 4 is an example of this:

if ($::osfamily == 'RedHat' and

It should be migrated to the new fact values as follows:

if ($facts['os']['family'] == 'RedHat and

and so forth. I will try to put together some pull requests, but sysctl has become unusable on modern Puppet due to this breaking change.

[jti-jzygmont]

+1

[KervyN]

+1

[lboclboc]

Any news on this?

[nebakke]

I've put a couple of comments in the PRs as well, forked the module and republished as purplejac/sysctl on the forge. I can always deprecate it out again if Thias comes back. There were already PRs for Puppet 8 and the sysctl spacing there, should work.