Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use custom model in send command #103

Merged

Conversation

cristiancalara
Copy link
Contributor

@cristiancalara cristiancalara commented Oct 11, 2022

In the send command, the default model was used even if the model was changed in the configuration file. This change allows the user to extend and overwrite the send function such that the package is more flexible.

Closes #129

@atymic
Copy link
Collaborator

atymic commented Mar 20, 2024

@cristiancalara could you resolve the test failures please :)

@cristiancalara cristiancalara force-pushed the use-custom-model-in-send-command branch from 43fbc1b to ce9a0c4 Compare April 12, 2024 07:44
@cristiancalara cristiancalara force-pushed the use-custom-model-in-send-command branch from ce9a0c4 to 05af2c3 Compare April 12, 2024 07:50
@cristiancalara
Copy link
Contributor Author

@atymic I fixed the failures

@jmverges
Copy link

@atymic this should be merged, I just found the same today

@atymic atymic merged commit 7a5a7d2 into thomasjohnkane:master Apr 16, 2024
5 checks passed
@atymic atymic mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snooze:send uses baked in model
3 participants