-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feature) [HELM] Allow for creating Role/RoleBinding for loading flags from ConfigMap #2196
Comments
Hello @yafanasiev, Adding a generic template for including custom YAML seems to be the most appropriate approach to avoid breaking changes. But I am happy to have your point of view on this. |
I went the generic manifests path, since indeed my use-case may not be as wide-spread and overloading chart with very specific values will just increase the complexity. Please review when you have time #2198 |
Requirements
Hi! First of all, thanks for a great project!
We are setting up go-feature-flag to load flag definitions from Kubernetes ConfigMap (relay-proxy itself is deployed in Kubernetes as well) and to make it work we have to add Role and RoleBinding to ServiceAccount created by chart (which is kind of expected as well), however might be not as convenient since you can't have Helm managing all the required resources.
Would you be open to adding those RBAC resources to the chart? Or at least a generic template allowing to pass any YAML to be rendered into resource. I would be happy to do a PR for this.
Just for reference, this is how sample RBAC setup looks like:
The text was updated successfully, but these errors were encountered: