fix: evaluationContextEnrichement with key env overridden by empty string #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Poignant <[email protected]>
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2367 +/- ##
=======================================
Coverage 86.07% 86.08%
=======================================
Files 102 102
Lines 3771 3773 +2
=======================================
+ Hits 3246 3248 +2
Misses 400 400
Partials 125 125 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
force-pushed
the
fix-context-enrichment-env
branch
from
f4d08ff
to
ef6ea19
Compare
|
mdsavian
approved these changes
Sep 18, 2024
thomaspoignant
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were overriding the context with
enveven if nothing was provided in the configuration causing an issue, when anevaluationContextEnrichementwith keyenvwas provided.In that case, the actual value was overridden by an empty string.
This PR fixes the issue and adds an order of preference
Environmenthas priority against theevaluationContextEnrichement,Original issue reported in slack.
Checklist
README.mdand/website/docs)