Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store Message as a Shared Constant String #80

Merged
merged 5 commits into from
Dec 23, 2023
Merged

Store Message as a Shared Constant String #80

merged 5 commits into from
Dec 23, 2023

Conversation

threeal
Copy link
Owner

@threeal threeal commented Dec 23, 2023 •
edited
Loading

This pull request resolves #75 by introducing the following changes:

  • Modifies the Error struct to be a class.
  • Modifies the error message to be stored as a const std::shared_ptr<const std::string>.
  • Adds an Error::message method for getting the error message string from the shared pointer.
  • Adds an Error::Error(const std::shared_ptr<const std::string>&) constructor.

@threeal threeal self-assigned this Dec 23, 2023
@threeal threeal added the feat label Dec 23, 2023
@threeal threeal added this to the Version 1.0.0 milestone Dec 23, 2023
@threeal threeal marked this pull request as ready for review December 23, 2023 19:20
@threeal threeal merged commit 7b9e05a into main Dec 23, 2023
6 checks passed
@threeal threeal deleted the store-msg-shared-string branch December 23, 2023 19:21
@threeal threeal mentioned this pull request Dec 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@threeal threeal

Labels
feat
Projects
None yet
Milestone
Version 1.0.0
Development

Successfully merging this pull request may close these issues.

Store Message as a Shared Constant String
1 participant
@threeal