Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Nginx configs from entrypoint and tests #50

Merged
merged 2 commits into from
Feb 2, 2019

Conversation

tiangolo
Copy link
Owner

@tiangolo tiangolo commented Feb 1, 2019

Generate Nginx configs from entrypoint instead of modifying live pre-existing files.

This is a more "purely functional" approach that improves stability, debuggability, etc.

It will also allow having a completely custom nginx.conf file to be used instead of the generated one.

It's a major refactor, but the tests ensure everything is working.

This (and the equivalent in uwsgi-nginx-flask) will solve: #49

It's also the first step to allow having a completely custom nginx.conf, that will solve:
#36
tiangolo/uwsgi-nginx-flask-docker#116
tiangolo/uwsgi-nginx-flask-docker#108
tiangolo/uwsgi-nginx-flask-docker#103

@tmerten
Copy link

tmerten commented Feb 4, 2019

@tiangolo : Thanks. Putting this in a separate upload.conf seems to be the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants