Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support picking a team in ESPN FF #2731

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

matthewfischer
Copy link
Contributor

This lets you pick your own team (or a team you are interested in) and only show that score.

This lets you pick your own team (or a team you are
interested in) and only show that score.
@tidbyt
Copy link

tidbyt bot commented Sep 25, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
🟡 Original Author The original author (jack-markle) does not match the PR author (matthewfischer)

@matthewfischer
Copy link
Contributor Author

matthewfischer commented Sep 25, 2024

@jack-markle hope you don't mind me adding this. I scored 151 this week and need to see my own glorious score only. I also do NOT know how to test the new setting, it may be broken. I can fix if so.

Also no idea on that build issue!

@jack-markle
Copy link
Contributor

jack-markle commented Sep 26, 2024

@jack-markle hope you don't mind me adding this. I scored 151 this week and need to see my own glorious score only. I also do NOT know how to test the new setting, it may be broken. I can fix if so.

Also no idea on that build issue!

Don't mind at all, this is awesome. I'll see if I can get around the build issue! @matthewfischer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants