grpc-sys: downgrade bindgen #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to rust-lang/cargo#5237, upgrading bindgen is not backward compatible. Signed-off-by: Jay Lee <[email protected]>
BusyJay
force-pushed
the
revert-upgrading-bindgen
branch
from
4ec8376
to
f65c429
Compare
|
Can you link to some known related issues we found here? |
Yes, it was provided in the PR description. |
hunterlxt
approved these changes
Mar 31, 2020
overvenus
approved these changes
Mar 31, 2020
|
I'm trying to upgrade a project from grpcio 0.4.7 and another dependency is already using bindgen 0.53.2. It seems my options right now are "don't upgrade" and "pin grpcio to 0.5.1". |
You didn't use either the 0.6 or the 0.7 release to bump the bindgen dependency. |
|
Indeed, I seem to forget about this. Can you send a PR so that I can get it merged when about releasing 0.8? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to rust-lang/cargo#5237, upgrading bindgen is not backward
compatible.