-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests fail with latest rustc. #250
Comments
No, I simply ran into the test failure while working on Debian rust packaging. |
Yes. I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to #232
The "validate" function tries to write data to a pipe from a pointer of unknown validity.
Unfortunately, the function tries to convert the possibly-invalid pointer to a slice, this is unsound and with recent rustc leads to the testsuite panicing
In Debian I fixed this by using libc::write directly instead of nix::unistd::write
https://salsa.debian.org/rust-team/debcargo-conf/-/blob/master/src/pprof/debian/patches/use-libc-write-for-validation.patch
The text was updated successfully, but these errors were encountered: