Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change sc_pc to __pc for loongarch64 #218

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Change sc_pc to __pc for loongarch64 #218

merged 1 commit into from
Jul 25, 2023

Conversation

xiangzhai
Copy link
Contributor

Hi,

I want to fix loongarch64 bindings as followed rust-lang/libc loongarch64 mcontext_t __pc.

Thanks,
Leslie Zhai

@xiangzhai
Copy link
Contributor Author

Hi @YangKeao

Could you review the patch and merge it on my behalf please?

Thanks,
Leslie Zhai

@xiangzhai
Copy link
Contributor Author

PING

YangKeao
YangKeao approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member

@xiangzhai Thanks. Sorry for the late reply. Once you signed-off this pull request (through git commit -s. If you need to modify the previous commit, you could use git commit -s --amend), I'll merge it 🍻 .

@xiangzhai
Copy link
Contributor Author

Hi @YangKeao

Thanks for your review!

Could you please review it again and merge it on my behalf please?

Thanks,
Leslie Zhai

@YangKeao YangKeao merged commit 13de063 into tikv:master Jul 25, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiangzhai @YangKeao