controllers: fix a flaky test (#6069)

Signed-off-by: Nick Santos <[email protected]>
tilt-dev · Mar 10, 2023 · 7935726 · 7935726
1 parent c314661
commit 7935726
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/internal/controllers/core/cmd/execer_unix_test.go b/internal/controllers/core/cmd/execer_unix_test.go
@@ -55,9 +55,8 @@ echo BACKGROUND $!
  require.NoError(t, err)
 
  // Old unix trick - signal to check if the process is still alive.
- time.Sleep(10 * time.Millisecond)
- err = grandkid.Signal(syscall.SIGCONT)
- if assert.Error(t, err) {
- assert.Contains(t, err.Error(), "process already finished")
- }
+ assert.Eventually(t, func() bool {
+ err := grandkid.Signal(syscall.SIGCONT)
+ return err != nil && strings.Contains(err.Error(), "process already finished")
+ }, time.Second, time.Millisecond)
 }