Skip to content

Commit

Permalink
circleci: update to node20 (#6237)
Browse files Browse the repository at this point in the history
Signed-off-by: Nick Santos <[email protected]>
  • Loading branch information
nicks authored Sep 29, 2023
1 parent 8f968b3 commit 879b0eb
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:

build-js:
docker:
- image: cimg/node:18.13
- image: cimg/node:20.7.0
steps:
- checkout
- run: make check-js
Expand Down Expand Up @@ -156,7 +156,7 @@ jobs:
resource_class: medium+
docker:
# keep image in sync with build.toast.yml
- image: docker/tilt-releaser@sha256:c6b9b55ab680da1a9b7b0fba33bc4f16c462084e4cae3dc5a07ffd91772e692c
- image: docker/tilt-releaser@sha256:ff4a71c0d18717cc9c646778cc426a0a4f916885c5fe7eb001f0eaee0d3483a0
environment:
DOCKER_CLI_EXPERIMENTAL: enabled
steps:
Expand All @@ -173,7 +173,7 @@ jobs:
resource_class: medium+
docker:
# keep image in sync with build.toast.yml
- image: docker/tilt-releaser@sha256:c6b9b55ab680da1a9b7b0fba33bc4f16c462084e4cae3dc5a07ffd91772e692c
- image: docker/tilt-releaser@sha256:ff4a71c0d18717cc9c646778cc426a0a4f916885c5fe7eb001f0eaee0d3483a0
environment:
DOCKER_CLI_EXPERIMENTAL: enabled
steps:
Expand Down
4 changes: 3 additions & 1 deletion scripts/release.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@ RUN set -exu \

RUN curl -sL https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add - && \
echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list && \
curl -sL https://deb.nodesource.com/setup_18.x | bash - && \
curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg && \
echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_20.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list && \
apt update && \
apt install -y -q --no-install-recommends \
nodejs \
yarn \
Expand Down
2 changes: 1 addition & 1 deletion web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,6 @@
"webpack": "5"
},
"engines": {
"node": "^16 || ^18"
"node": "^16 || ^18 || ^20"
}
}
4 changes: 1 addition & 3 deletions web/src/logfilters.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,7 @@ describe("Log filters", () => {
it("throws an error when input text is invalid regex", () => {
expect(() =>
parseTermInput("/(missing)? parenthesis)/")
).toThrowError(
"Invalid regular expression: /(missing)? parenthesis)/: Unmatched ')'"
)
).toThrowError(/Invalid regular expression/)
})
})
})
Expand Down

0 comments on commit 879b0eb

Please sign in to comment.