Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force restart does not rebuild image #5913

Closed
nhomble opened this issue Aug 4, 2022 · 3 comments · Fixed by #5977
Closed

force restart does not rebuild image #5913

nhomble opened this issue Aug 4, 2022 · 3 comments · Fixed by #5977
Labels
bug Something isn't working

Comments

@nhomble
Copy link

nhomble commented Aug 4, 2022

Expected Behavior

Given a resource from docker_compose that points to a Dockerfile, I expected the restart button to rebuild my image.

Current Behavior

The same image is restarted.

Steps to Reproduce

  1. used the button described in https://blog.tilt.dev/2019/11/14/force-update.html
  2. found similar discussion in Force rebuild / redeploy #1012

Context

tilt doctor Output

$ tilt doctor
Tilt: v0.30.5, built 2022-07-14
System: darwin-arm64
---
Docker
- Host: unix:///var/run/docker.sock
- Server Version: 20.10.14
- API Version: 1.41
- Builder: 2
- Compose Version: v2.5.1
Thanks for seeing the Tilt Doctor!
Please send the info above when filing bug reports. 💗

About Your Use Case

As I was developing my image, I was adding new files to my image (passed as a volume). On a restart, I wasn't seeing the changes.

My Tiltfile is minimal

docker_compose('docker-compose.yml')

Where the docker-compose.yml looks like

version: '3.9'
services:
  svc:
    build: ./thing

My workaround is to:

  1. disable my resource
  2. enable my resource
  3. restart
@nhomble nhomble added the bug Something isn't working label Aug 4, 2022
@nicks
Copy link
Member

nicks commented Aug 5, 2022

thanks for filing! ya, i think this might just be an oversight

@nhomble
Copy link
Author

nhomble commented Aug 6, 2022

Happy to help out as well! I'm a big fan of tilt @nicks

@mleiter06
Copy link

This is a big one for me.

Additionally, it seems like this is part of the same issue. When I click the force restart button, the logs do not reattach. When I click disable/enable like nhomble suggested, the logs DO reattach.

nicks added a commit to nicks/tilt that referenced this issue Nov 18, 2022
This is similar to how it works for the kubernetes controllers;
this is just porting the same logic to the compose controllers.

fixes tilt-dev#5913
nicks added a commit to nicks/tilt that referenced this issue Nov 18, 2022
This is similar to how it works for the kubernetes controllers;
this is just porting the same logic to the compose controllers.

fixes tilt-dev#5913

Signed-off-by: Nick Santos <[email protected]>
nicks added a commit that referenced this issue Nov 18, 2022
This is similar to how it works for the kubernetes controllers;
this is just porting the same logic to the compose controllers.

fixes #5913

Signed-off-by: Nick Santos <[email protected]>

Signed-off-by: Nick Santos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants