Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing argument for echo_off #6369

Closed
nicks opened this issue May 6, 2024 · 1 comment · Fixed by #6370
Closed

missing argument for echo_off #6369

nicks opened this issue May 6, 2024 · 1 comment · Fixed by #6370
Labels
bug Something isn't working

Comments

@nicks
Copy link
Member

nicks commented May 6, 2024

This works OK:

live_update=[run('./script.sh', trigger='package.json')]

This gives an error:

live_update=[run('./script.sh', 'package.json')]

The error is:

Error in run: run: missing argument for echo_off

I think there's an underlying starlark interpreter bug here but not sure what it is yet.
@nicks nicks added the bug Something isn't working label May 6, 2024
nicks added a commit that referenced this issue May 6, 2024
@nicks
tiltfile: explicitly mark echo_off as optional
1597205 
fixes #6369

i think there's an underlying starlark bug here,
since it's supposed to be marking this as optional
implicitly, and the enforcement of optionality
seems to be buggy.
@nicks nicks mentioned this issue May 6, 2024
Merged
nicks added a commit that referenced this issue May 6, 2024
@nicks
tiltfile: explicitly mark echo_off as optional
06b3501 
fixes #6369

i think there's an underlying starlark bug here,
since it's supposed to be marking this as optional
implicitly, and the enforcement of optionality
seems to be buggy.

Signed-off-by: Nick Santos <[email protected]>
nicks added a commit that referenced this issue May 6, 2024
@nicks
tiltfile: explicitly mark echo_off as optional (#6370)
191178e 
fixes #6369

i think there's an underlying starlark bug here,
since it's supposed to be marking this as optional
implicitly, and the enforcement of optionality
seems to be buggy.

Signed-off-by: Nick Santos <[email protected]>
@nicks
Copy link
Member Author

nicks commented May 6, 2024

filed the starlark bug upstream as google/starlark-go#544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tiltfile: explicitly mark echo_off as optional tilt-dev/tilt
1 participant
@nicks