Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildcontrol: remove crash rebuilds #5633

Merged
merged 1 commit into from
Mar 28, 2022
Merged

buildcontrol: remove crash rebuilds #5633

merged 1 commit into from
Mar 28, 2022

Conversation

nicks
Copy link
Member

@nicks nicks commented Mar 25, 2022

Hello @landism,

Please review the following commits I made in branch nicks/liveupdate:

2dc3577 (2022-03-25 14:13:12 -0400)
buildcontrol: remove crash rebuilds

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks requested a review from landism March 25, 2022 18:16
@nicks nicks force-pushed the nicks/liveupdate branch 2 times, most recently from 62798a3 to d94c51c Compare March 25, 2022 18:21
landism
landism approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@landism landism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nicks nicks merged commit 044acd5 into master Mar 28, 2022
@nicks nicks deleted the nicks/liveupdate branch March 28, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landism landism landism approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicks @landism