script: use Go 1.18 image for Toast tasks #5660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed `Dockerfile.toast` but forgot to update the reference to the new image in `toast.yml`, so it was still using a 1.17 based image. This meant that `make wire` would fail as it couldn't handle parsing generics. All tasks have been re-run as part of this commit to ensure they are working and commit any minor changes resulting from the upgrade.
nicks
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed
Dockerfile.toastbut forgot to update the referenceto the new image in
toast.yml, so it was still using a 1.17based image.
This meant that
make wirewould fail as it couldn't handle parsinggenerics.
All tasks have been re-run as part of this commit to ensure they
are working and commit any minor changes resulting from the upgrade.