Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: update the document title and favicon when Tilt UI disconnects #5678

Merged
merged 3 commits into from
Apr 13, 2022

Conversation

lizzthabet
Copy link
Contributor

This PR updates the document title and page favicon when there's a socket connection issue, so it's clearer to users looking at a browser tab title that Tilt has disconnected.

Closes #5650

@lizzthabet lizzthabet requested review from hyu and nicks April 7, 2022 20:36
@lizzthabet lizzthabet self-assigned this Apr 7, 2022
Copy link
Member

@nicks nicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

web/src/ResourceStatusSummary.tsx Outdated Show resolved Hide resolved
web/src/ResourceStatusSummary.tsx Outdated Show resolved Hide resolved
@lizzthabet lizzthabet merged commit 66347c5 into master Apr 13, 2022
@lizzthabet lizzthabet deleted the lizz/chore/doc-title-on-disconnect branch April 13, 2022 15:21
@chrisjohnson
Copy link

<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tilt icon change during connection failure
3 participants