apis: add an api for the dockercompose log streamer #5715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is almost all boilerplate and copying the podlogstream |
milas
approved these changes
Apr 22, 2022
| // A specification of the project the service belongs to. | ||
| // | ||
| // Each service spec keeps its own copy of the project spec. | ||
| Project DockerComposeProject `json:"project" protobuf:"bytes,2,opt,name=project"` |
There was a problem hiding this comment.
Just curious, what's the reason for embedding the project vs having something like DockerComposeService string that points to the main API object?
There was a problem hiding this comment.
ya, i went back and forth on this
my main thinking is that we should have the log streamers be independent objects that you can use without deploying anything, much like PodLogStream, and trying to keep the general pattern as much like PodLogStream as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @milas,
Please review the following commits I made in branch nicks/dclogs3:
f3c90c0 (2022-04-21 13:10:43 -0400)
apis: add an api for the dockercompose log streamer
Code review reminders, by giving a LGTM you attest that: