web: don't display the account menu item when offline snapshots are enabled #5799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #13514: Hide accounts menu item with offline snapshots. |
nicks
approved these changes
May 10, 2022
|
|
||
| const hideAccountDialog = features.isEnabled(Flag.OfflineSnapshotCreation) | ||
| if (hideAccountDialog) { | ||
| return null |
There was a problem hiding this comment.
this might be a silly question...but shouldn't it be impossible to hit this codepath? because disabling the dialog happens further upstream.
There was a problem hiding this comment.
not a silly question! i'm being extra-defensive in this code path and mostly added this case due to my local testing. you can open the account dialog, enable the feature flag, and the dialog will stick around even though the menu item is gone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hides the account menu item and dialog when offline snapshot creation is enabled. Since people won't need an account to create an offline snapshot, account information is no longer relevant.
Closes ch13514