controllers: move Session into a reconciler #5996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not much really changed, the controller was already structured a lot like a reconciler. the main bit is moving the Session creation to the tiltfile reconciler. |
A few reasons to do this: - Now that we have session settings in the tiltfile, we need a way to propagate data from the tiltfile to the Session - Reconcilers make it way easier to implement async and wait logic, because they have a bunch of nice queue scheduling underneath. Signed-off-by: Nick Santos <[email protected]>
nicksieger
approved these changes
Dec 20, 2022
Co-authored-by: Nick Sieger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few reasons to do this:
Now that we have session settings in the tiltfile, we need a way to propagate data from the tiltfile to the Session
Reconcilers make it way easier to implement async and wait logic, because they have a bunch of nice queue scheduling underneath.
Signed-off-by: Nick Santos [email protected]