Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: sidebar collapse/expand toggle #6076

Merged
merged 4 commits into from
Mar 22, 2023

Conversation

bshore
Copy link
Contributor

@bshore bshore commented Mar 14, 2023

Relates to #5771 (comment)

This introduces the Proof of Concept collapsible Sidebar mentioned in the linked comment.

@nicks nicks self-requested a review March 15, 2023 15:13
@nicks
Copy link
Member

nicks commented Mar 16, 2023

thanks for prototyping this up. a couple UI observations:

  • the hamburger menu is pretty dark, usually our icons are white
  • there's not any way to tell what service you're on when you're in this mode
  • currently the sidebar is draggable, and this feature interacts weirdly with the dragger (see screenshot)

Screenshot from 2023-03-16 18-58-14

one idea we had played around with was using icons instead of names for each service (auto-assigning icons in some deterministic order)

what do you think of triggering the collapsed mode when you drag the sidebar "left" of a current point?

@bshore
Copy link
Contributor Author

bshore commented Mar 19, 2023

  • Fixes hamburger menu icon color (I use a dark reader extension so I didn't even notice 😅 )
  • Adds a title row when sidebar is collapsed
  • Adds a dragger breakpoint to fix the weirdness when expanding, and will auto-collapse when dragging to the left (upon releasing)
    • There's still a little bit of weirdness when expanding from fully collapsed, but once the breakpoint is hit, all resources come back
  • Re: Icons - I'd love to give this a shot, maybe not in this PR but in a follow-up?

Copy link
Member

@nicks nicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

i'm not so sure about the expand/collapse icons, but can think more about what they should be

ya, the service icons was kind of a silly idea that i thought would fit in well with some of your earlier explorations

@nicks nicks merged commit 5566fb2 into tilt-dev:master Mar 22, 2023
@bshore bshore deleted the enhancement/toggleable-sidebar branch March 22, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants