Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: use upstream fsevents #6095

Merged
merged 2 commits into from
Apr 12, 2023
Merged

vendor: use upstream fsevents #6095

merged 2 commits into from
Apr 12, 2023

Conversation

milas
Copy link
Contributor

@milas milas commented Apr 7, 2023

See #6071 for original PR - I rebased the dependency update and then removed the code causing trouble on the Tilt side.

nicks and others added 2 commits April 7, 2023 13:14
No longer necessary with v0.1.1 of `fsnotify/fsevents` - causes
the process to never see _any_ file writes.

Signed-off-by: Milas Bowman <[email protected]>
@milas milas added the dependencies Pull requests that update a dependency file label Apr 7, 2023
@milas milas requested a review from nicks April 7, 2023 17:16
@milas milas self-assigned this Apr 7, 2023
Copy link
Member

@nicks nicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@milas milas merged commit aa51edc into master Apr 12, 2023
@milas milas deleted the upstream-fsevents branch April 12, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants