fix: never set the image pull policy to never #6134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realtimetodie
force-pushed
the
fix-remove-annoyance
branch
2 times, most recently
from
37b1d6a
to
ebe2a7e
Compare
Signed-off-by: so8wuyaicohv1ohy <[email protected]>
realtimetodie
force-pushed
the
fix-remove-annoyance
branch
from
ebe2a7e
to
61ebdd2
Compare
|
hmmm, this isn't quite right, let's discuss on the issue. also -- not sure why you think this was introduced in #5786, ImagePullPolicy: Never was like one of the very first features we added to Tilt because it's unusable without it in many cases AFAIR; here's a reference to when we were talking about it in 2018! #124 |
|
You are right, I think this needs to be fixed in the reconciler instead, since this issue is only occuring on a non-docker setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the ImagePullPolicy was set to Never for no apparent reason. This was originally introduced in #5786.
Related