Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add skip_crds parameter to helm functions #6182

Merged
merged 1 commit into from
Jul 27, 2023
Merged

chore: add skip_crds parameter to helm functions #6182

merged 1 commit into from
Jul 27, 2023
+9 −4

Conversation

kahirokunn
Copy link
Contributor

@kahirokunn kahirokunn commented Jul 25, 2023 •
edited
Loading

@kahirokunn kahirokunn mentioned this pull request Jul 25, 2023
Closed
nicks
nicks reviewed Jul 25, 2023
View reviewed changes
internal/tiltfile/files.go Outdated Show resolved Hide resolved
@nicks
Copy link
Member

nicks commented Jul 25, 2023

thanks! can you also add this to the API documentation? it's here:
https:/tilt-dev/tilt/blob/master/internal/tiltfile/api/__init__.py#L724

@kahirokunn
Copy link
Contributor Author

@nicks done. how about now?

nicks
nicks approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@nicks nicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicks nicks merged commit ecf3dea into tilt-dev:master Jul 27, 2023
1 check passed
@kahirokunn
Copy link
Contributor Author

@nicks hello! May I ask when you plan to release it?

@nicks
Copy link
Member

nicks commented Aug 2, 2023

we usually do a release every 2-3 weeks, depending on what's in flight.

@kahirokunn
Copy link
Contributor Author

Okay. Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicks nicks nicks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kahirokunn @nicks