docker: extra_hosts argument to add hosts to a container’s /etc/hosts… #6185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file Docker CLI has a `--add-host` argument This adds a `extra_hosts` argument to `docker_build` which will get passed through to Docker/BuildKit for adding ExtraHosts. Signed-off-by: Azanul <[email protected]>
nicks
approved these changes
Jul 28, 2023
Signed-off-by: Azanul <[email protected]>
Signed-off-by: Azanul <[email protected]>
I've generated the code and updated the tests, now the CI is passing |
nicks
approved these changes
Aug 1, 2023
nicks
added a commit
to nicks/tilt
that referenced
this pull request
Aug 29, 2023
feature added in tilt-dev#6185 Signed-off-by: Nick Santos <[email protected]>
nicks
added a commit
that referenced
this pull request
Aug 30, 2023
feature added in #6185 Signed-off-by: Nick Santos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6139
Emulates Docker CLI's
--add-hostargumentThis adds a
extra_hostsargument todocker_buildwhich will get passed through to Docker/BuildKit for adding ExtraHosts.