dockercompose: add wait_for_healthy optional argument to docker_compose (#2239) #6329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se (tilt-dev#2239) Signed-off-by: Kinland <[email protected]>
Signed-off-by: Kinland <[email protected]>
nicks
reviewed
Mar 6, 2024
internal/tiltfile/api/__init__.py
Outdated
| @@ -245,7 +245,7 @@ def docker_build(ref: str, | |||
| """ | |||
| pass | |||
|
|
|||
| def docker_compose(configPaths: Union[str, Blob, List[Union[str, Blob]]], env_file: str = None, project_name: str = "", profiles: Union[str, List[str]] = []) -> None: | |||
| def docker_compose(configPaths: Union[str, Blob, List[Union[str, Blob]]], env_file: str = None, project_name: str = "", profiles: Union[str, List[str]] = [], wait_for_healthy = False) -> None: | |||
There was a problem hiding this comment.
what do you think of changing the param to wait to match the flag?
There was a problem hiding this comment.
That was my initial choice, actually. I was concerned in the context of Tilt it might not be obvious, but I'll chalk that up to "coding in the middle of the night," as it literally says docker_compose right there 😁
There was a problem hiding this comment.
sorry for the delay - this is done now
Signed-off-by: Kinland <[email protected]>
|
Great! i was waiting for this to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tentative solution for #2239
I imagine the ideal case would be to do something fancy in
internal/dockercompose/state.goto check the status, but as far as I could tell, the library that is being used under the hood there doesn't support checking whether a container is healthy.Simply adding
--waitto the docker compose up command seems to make my health checks work properly. This might have side effects, but in the project that I've been submitting all these PRs for, it makes the race condition problems go away and I don't see any issues.Tests seem to pass locally.