Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiltfile: add echo_off to live update run #6351

Merged
merged 2 commits into from
Apr 11, 2024
Merged

tiltfile: add echo_off to live update run #6351

merged 2 commits into from
Apr 11, 2024

Conversation

muripic
Copy link
Contributor

@muripic muripic commented Apr 8, 2024

This PR aims to solve issue #6054.

It adds an echo_off parameter (as in the local command, see https://docs.tilt.dev/api.html#api.local) to silence printing out the command that is being run.

Ran make test and also tested by running Tilt with the built binary:

Without echo_off:
Screenshot 2024-04-05 at 14 51 52

With echo_off:
Screenshot 2024-04-05 at 14 51 24

Signed-off-by: Muriel Picone Farias <[email protected]>
Signed-off-by: Muriel Picone Farias <[email protected]>
Copy link
Member

@nicks nicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice change! lgtm

@nicks nicks merged commit 05beffd into tilt-dev:master Apr 11, 2024
8 checks passed
@muripic
Copy link
Contributor Author

muripic commented Apr 12, 2024

Thank you for your review @nicks 🙇‍♀️ ❤️
I see that the tests in master have failed due to a timeout 😞 I think a retry should work, right?
Also, do you think it'd be possible to have a release soon? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants