[Reporting/Visualisation] DOM attributes for reporting integration ar…

…e missing (elastic#52109)
timductive · Dec 16, 2019 · 56cb42c · 56cb42c
1 parent 99aeada
commit 56cb42c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/src/legacy/core_plugins/kibana/public/visualize/embeddable/visualize_embeddable.ts b/src/legacy/core_plugins/kibana/public/visualize/embeddable/visualize_embeddable.ts
@@ -313,6 +313,7 @@ export class VisualizeEmbeddable extends Embeddable<VisualizeInput, VisualizeOut
 
  div.setAttribute('data-test-subj', 'visualizationLoader');
  div.setAttribute('data-shared-item', '');
+ div.setAttribute('data-shared-item-container', '');
  div.setAttribute('data-rendering-count', '0');
  div.setAttribute('data-render-complete', 'false');
 

diff --git a/test/functional/apps/visualize/_shared_item.js b/test/functional/apps/visualize/_shared_item.js
@@ -30,7 +30,7 @@ export default function ({ getService, getPageObjects }) {
  await PageObjects.common.navigateToApp('visualize');
  });
 
- it('should have the correct data-shared-item title and description', async function () {
+ it('should have the correct data-shared-item title and description, and sharedItemContainer should exist', async function () {
  const expected = {
  title: 'Shared-Item Visualization AreaChart',
  description: 'AreaChart'
@@ -41,6 +41,8 @@ export default function ({ getService, getPageObjects }) {
  const { title, description } = await PageObjects.common.getSharedItemTitleAndDescription();
  expect(title).to.eql(expected.title);
  expect(description).to.eql(expected.description);
+ const sharedItemContainers = await PageObjects.common.getSharedItemContainers();
+ expect(sharedItemContainers.length).to.be(1);
  });
  });
  });

diff --git a/test/functional/page_objects/common_page.ts b/test/functional/page_objects/common_page.ts
@@ -287,6 +287,11 @@ export function CommonPageProvider({ getService, getPageObjects }: FtrProviderCo
  };
  }
 
+ async getSharedItemContainers() {
+ const cssSelector = '[data-shared-item-container]';
+ return find.allByCssSelector(cssSelector);
+ }
+
  async ensureModalOverlayHidden() {
  return retry.try(async () => {
  const shown = await testSubjects.exists('confirmModalTitleText');