Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering in Windows #14

Closed
ghost opened this issue Dec 17, 2015 · 9 comments
Closed

Rendering in Windows #14

ghost opened this issue Dec 17, 2015 · 9 comments

Comments

@ghost
Copy link

ghost commented Dec 17, 2015

Works fantastic in Linux, zero issues.
html files sent to Windows computers give mixed results. Chrome works as intended, Internet Explorer shows nothing. Firefox shows plot, axes can be moved around, but no selection is possible [I use 1D axis multi].

@timelyportfolio
Copy link
Owner

Thanks so much for the report. I was not aware of these problems even though I use Windows. Unfortunately, I don't have the resources to maintain the underlying parallel-coordinates JavaScript library, so not sure how best to handle. Darn.

@ghost
Copy link
Author

ghost commented Dec 18, 2015

Darn indeed...I use this plot in markdown/html reports for (chemical) industry worldwide and it is the single most important plot for everybody once they get the hang of it. User interaction with plots is a tremendous step forward. (BTW another interesting (static) parallel coord app is Norman Matloff's freqparcoord library).

At least good to know that you don't have this problem on your machine. I will try rendering on a Windows machine if I get access to one. And thanks for all your work, really appreciate (and use!).

@timelyportfolio
Copy link
Owner

Great to hear that you are using. I want to clarify that I do experience these same troubles. 1d works fine but 1d-multi does not on Firefox, and there is no error in the console. In IE Edge, I get console error because __.data is an object so there is no forEach() method. I will file an issue over at parallel-coordinates to see if they might be interested in working on this.

@timelyportfolio
Copy link
Owner

I think I have traced the Firefox issue to humanitiesplusdesign/d3.svg.multibrush#2. I'll update d3.svg.multibrush. I hope it will fix at least one of the issues.

@timelyportfolio
Copy link
Owner

@carbonmetrics aec1888 should fix the problem in Firefox+Windows. I tested on my machine, and it works.

@ghost
Copy link
Author

ghost commented Dec 18, 2015

Works here too. Many hanks, on behalf of many people worldwide checking their emissions data before the end of the year with this tool.

@GHDharma
Copy link

GHDharma commented Aug 21, 2017

The first issue where the rendering failed due to "__.data.forEach() method" not available can be fixed in parcoords.js.
In two places the code checks for an IF condition '....constructor.name === "Object"'. In IE, the .constructor.name return "undefined" instead of "Object". Hence if we add 'typeof x.data === "object"' as an OR condition, then the parcoords renders fine.
The fixes needed are on line 119 and 193.
However, I still have issues in reordering the axis by double-clicking the axis label. The lines get reordered but the values in axis doesn't. I'll check further on that.

@timelyportfolio
Copy link
Owner

Thanks for the report. What version of IE are you using?

@GHDharma
Copy link

GHDharma commented Sep 1, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants