Extend Object prototype for message instances #618
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #582, message instances don't behave exactly like simple objects, as their prototype only includes a
Symbol("protobuf-ts/message-type")
field and is missing fields normally present in a simple object (e.g.constructor
). For us, this specifically causes an issue when using mobx to observe changes to message instances - it only allows observing objects that have aconstructor
method in their prototype that matches the method for simple objects.This fixes the problem by copying the default object prototype and adding a
Symbol("protobuf-ts/message-type")
field, rather than starting from an empty prototype.