Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: URL and Identifier system not being correctly set when mapping_set_id not generated #5

Open
joeflack4 opened this issue Jul 12, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@joeflack4
Copy link
Contributor

Overview

If choosing a static mapping_set_id in the inputs (which is what we want to do; see #4), the url that gets created is wrong. And because that is wrong, the identifier.system also is wrong. See example below. This is the result of me setting a # mapping_set_id: "fa10c6d4-614c-4762-93e4-782d86eede41" in the metadata comment of the input TSV.

Example:

 {
   "resourceType": "ConceptMap",
-  "url": "https://w3id.org/sssom/mappings/fa10c6d4-614c-4762-93e4-782d86eede41",
+  "url": "fa10c6d4-614c-4762-93e4-782d86eede41",
   "identifier": [
     {
-      "system": "https://w3id.org/sssom/mappings/",
-      "value": "https://w3id.org/sssom/mappings/fa10c6d4-614c-4762-93e4-782d86eede41"
+      "system": "/",
+      "value": "fa10c6d4-614c-4762-93e4-782d86eede41"
     }
   ],
   "name": "fa10c6d4-614c-4762-93e4-782d86eede41",
@joeflack4 joeflack4 self-assigned this Jul 12, 2024
@joeflack4 joeflack4 added the bug Something isn't working label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Soon
Development

No branches or pull requests

1 participant